ThemeShaper Forums » Thematic

0.9.5.1 Update Questions

(7 posts)
  • Started 11 years ago by LegendsCrazy
  • Latest reply from LegendsCrazy
  • This topic is not resolved
  1. Just wanted to check to see if it was safe to remove these functions from my child functions.php with the latest release of 0.9.5.1

    The first one is the threaded comments functionality:

    <?php
    function my_comments($comment, $args, $depth) {
    $GLOBALS['comment'] = $comment;
    $GLOBALS['comment_depth'] = $depth;
    ?>
    <li id="comment-<?php comment_ID() ?>" class="<?php thematic_comment_class() ?>">
    <?php echo gtcn_comment_numbering($comment->comment_ID, $args); ?>
    <div class="comment-author vcard"><?php thematic_commenter_link() ?></div>
    <div class="comment-meta"><?php printf(__('Posted %1$s at %2$s <span class="meta-sep">|</span> Permalink', 'thematic'),
    get_comment_date(),
    get_comment_time(),
    '#comment-' . get_comment_ID() );
    edit_comment_link(__('Edit', 'thematic'), ' <span class="meta-sep">|</span> <span class="edit-link">', '</span>'); ?></div>
    <?php if ($comment->comment_approved == '0') _e("\t\t\t\t\t<span class='unapproved'>Your comment is awaiting moderation.</span>\n", 'thematic') ?>
    <div class="comment-content">
    <?php comment_text() ?>
    </div>

    <?php // echo the comment reply link with help from Justin Tadlock http://justintadlock.com/ and Will Norris http://willnorris.com/
    if($args['type'] == 'all' || get_comment_type() == 'comment') :
    comment_reply_link(array_merge($args, array(
    'reply_text' => __('Reply','thematic'),
    'login_text' => __('Log in to reply.','thematic'),
    'depth' => $depth,
    'before' => '<div class="comment-reply-link">',
    'after' => '</div>'
    )));
    endif;
    ?>
    <?php }

    function my_callback() {
    $content = 'type=comment&callback=my_comments';
    return $content;
    }
    add_filter('list_comments_arg', 'my_callback');

    and the second had to do with the index insert disappearing in the previous version:

    function remove_index_loop() {
    remove_action('thematic_indexloop', 'thematic_index_loop');
    }
    add_action('init', 'remove_index_loop');

    function fix_index_loop() {
    global $options;
    foreach ($options as $value) {
    if (get_option( $value['id'] ) === FALSE) { $$value['id'] = $value['std']; }
    else { $$value['id'] = get_option( $value['id'] ); }
    }
    /* Count the number of posts so we can insert a widgetized area */ $count = 1;
    while ( have_posts() ) : the_post() ?>

    <div id="post-<?php the_ID() ?>" class="<?php thematic_post_class() ?>">
    <?php thematic_postheader(); ?>
    <div class="entry-content">
    <?php thematic_content(); ?>

    <?php wp_link_pages('before=<div class="page-link">' .__('Pages:', 'thematic') . '&after=</div>') ?>
    </div>
    <?php thematic_postfooter(); ?>
    </div><!-- .post -->

    <?php comments_template();

    if ($count==$thm_insert_position) {
    get_sidebar('index-insert');
    }
    $count = $count + 1;
    endwhile;
    }
    add_action('thematic_indexloop', 'fix_index_loop');

    Thanks in advance!

    Posted 11 years ago #
  2. Hi Dale,

    need to check the comments stuff .. the fix_index_loop() is still needed. I'm working on some code to speed up Thematic. The fix will be part of this code.

    Chris

    Posted 11 years ago #
  3. Thanks Chris!

    Posted 11 years ago #
  4. Dale .. a short update for the fix_index_loop() thing. This is no longer needed with the latest SVN copy.

    Need to look through my collected links on my iPhone. I found something that makes it easier to deal with the comment numbers.

    Chris

    Posted 11 years ago #
  5. Thanks Chris!

    Posted 11 years ago #
  6. Hi Dale,

    I'm sorry .. the link I had was dealing with changing the standard comment form against the one of the plugin. That was one thing I tested when you asked the first time for the integration.

    Using the plugin's comment form would require to much design work to fit this into the Thematic standards.

    And .. basically it's not different from what we did.

    Chris

    Posted 10 years ago #
  7. No problem Chris. Thanks for looking into it. I'm thinking about removing the Greg's Threaded Comment Numbering plug-in anyway. I don't think I really need that functionality, since no-one ever comments on my posts :(

    Thanks again.

    Posted 10 years ago #

RSS feed for this topic

Reply

You must log in to post.