ThemeShaper Forums

Help In Shaping WordPress Themes

Register or log in:

Username:
Password:

Remember me

ThemeShaper Forums » Thematic

1. 

   ridgely
   Member

   Hi, I started this thread so that as we test the latest release, we could bring any bugs to Chris & Gene's attention without having to subject them to reading 1,000,001 bug threads.

   Search/404 Page Error
   First one I noticed happened in both my local and live sites when I tested the 404 page. I got the 404 message: "Sorry, but nothing matched your search criteria. Please try again with some different keywords."

   Below that I got:
   Fatal error: Call to undefined function blog_info() in C:\xampp\htdocs\wordpress\wp-content\themes\thematic\search.php on line 50

   Line 50 is:
   <form id="noresults-searchform" method="get" action="<?php blog_info('url') ?>/">

   (As mentioned, this is on the latest thematic repo release. I had entered the defined functions listed in the release notes.)

   Posted 12 years ago #
2. 

   ridgely
   Member

   Corrected to:
   <form id="noresults-searchform" method="get" action="<?php bloginfo('url'); ?>">

   This fixed everything and restored my sidebar.

   *NOTE: 99.9% of the time, I do not advocate, advise or support altering thematic theme files.*

   Posted 12 years ago #
3. 

   em hr
   Moderator

   Thank you for your attention to this Ridgley. It will be resolved shortly.

   -Gene

   Posted 12 years ago #
4. 

   ridgely
   Member

   One other thing re: thematic_compatible_body_class

   After I included the requested define('THEMATIC_COMPATIBLE_BODY_CLASS', true); the body classes on my drawing page (http://ridgelyschantz.com/drawing/) showed up as this:
   wordpress blogid-1 y2010 m10 d11 h10 not-singular loggedin windows firefox ff3
   (Painting does the same thing: http://ridgelyschantz.com/painting/)

   Commented out:define('THEMATIC_COMPATIBLE_BODY_CLASS', true);
   The body classes shown: logged-in custom-post-type-archive custom-post-type-drawing-archive windows firefox ff3
   Obviously, for me the latter is preferable, but runs counter to review requirements. Wondering if there's a workaround.

   Posted 12 years ago #
5. 

   em hr
   Moderator

   All the thematic_compatible_body_class constant does is toggle between using WordPress' body_class function or using Thematic's thematic_body_class function.

   If you prefer the WP function's classes then there is no need to define the constant as true.

   The theme Review requirements relate only to Thematic meeting the criteria for inclusion in the WordPress Theme Repo. You can use the theme however you want regardless of those requirements.

   The constants just provide backward compatibility for Thematic's previous functions while keeping up with the current Theme Review Guidelines.

   Posted 12 years ago #
6. 

   ridgely
   Member

   Oh, ok. Gotcha. Sorry to inundate you guys -- you have, as always, done an awesome job.

   Posted 12 years ago #
7. 

   helgatheviking
   Moderator

   hey gene- i thought thematic supported dynamic body classes for custom post types? i am having a similar problem in that my 'portfolio' type isn't getting any body classes that i can use to target the CSS on the portfolio pages.

   Posted 12 years ago #
8. 

   WraithKenny
   Member

   just as a note here:

   thematic has a few new sf-menu rules, for example, ".windows .sf-menu a { padding: 9px 13px 10px; }" which beat the specificity of my child theme's rules.

   Just add more specificity to your rules if you have issue with this, i.e. "#access .sf-menu a { padding: 4px; }"

   Posted 12 years ago #
9. 

   Thompson
   Member

   @helgatheviking, I had a similar issue. I posted my solution to create custom post type body classes here: http://programming.thematic4you.com/2010/06/how-to-install-a-thematic-child-theme/#comment-66

   Posted 12 years ago #
10. 

    ridgely
    Member

    @helgatheviking: That's what happened to me. I'm using Simple Custom Post Type Archives, the body class for which shows up on the WP body class, but once you declare Thematic Compatible, anything that could indicate custom post type, page template, what-have-you: GONE.

    Posted 12 years ago #
11. 

    em hr
    Moderator

    @Helga I added *some* support for custom post types extending the "paged" classes for them (those did not work before)

    I need to look back into this to extend it. Would you start a thread for your problems and expectations with this?

    Posted 12 years ago #
12. 

    em hr
    Moderator

    0.9.7.7 is live on WordPress>Extend and fixes the fatal error. Thanks again.

    Posted 12 years ago #
13. 

    cas
    Member

    I've got the same problem as helgatheviking - I want to enable the THEMATIC_COMPATIBLE_BODY_CLASS on my child-theme, but because I'm using body.single-customposttypename to define styles for the #container and #content divs (to widen them to full-width) and commenting out the sidebar on my single-CPT.php template page - if I enable THEMATIC_COMPATIBLE_BODY_CLASS, body.single-customposttypename goes away. How do I get Thematic to add the dynamic CPT body class like WP does by default?

    Posted 12 years ago #

RSS feed for this topic

Topic Closed

This topic has been closed to new replies.