ThemeShaper Forums » Thematic

[closed]

Breaking things to fix others

(3 posts)
  • Started 4 years ago by Chris
  • Latest reply from helgatheviking
  • This topic is not a support question

Tags:

  1. Hi,

    I know, that I promised not to break existing child themes with future versions of Thematic. But sometimes it is necessary to break things 'cause we need to fix others.

    Read more about Breaking things to fix others

    Chris

    Posted 4 years ago #
  2. thanks for the head's up, Chris!
    I am using version .9.6.1 of Thematic ( I haven't really figured out SVN yet), so would this be an issue for me?

    I've noted the change to echo, but as I use the wp_page_menu twice in my functions, can you let me know what changes I may have to make, if any?
    relevant code:

    // Adds a home link to your menu
    // http://codex.wordpress.org/Template_Tags/wp_page_menu
    function childtheme_menu_args($args) {
        $args = array(
            'show_home' => 'Home',
            'sort_column' => 'menu_order',
            'menu_class' => 'menu',
            'echo' => true
        );
        return $args;
    }
    add_filter('wp_page_menu_args','childtheme_menu_args');
    
    //add links to the menu
    function child_add_menu_items($output) {
    	$my_code = '<li><a href="http://qwstnevrythg.com/" target="blank">Question Everything</a></li><li><a href="http://astore.amazon.com/fdbrightly-20" target="blank">The Shelf</a></li></ul>';
    	return str_replace('</ul>',$my_code, $output);
    }
    add_filter('wp_page_menu','child_add_menu_items');

    I haven't noticed any difference to my theme yet, nothing appears to be broken....but it's coming, isn't it :)
    Thanks in advance for any help you can offer!

    Posted 4 years ago #
  3. Thanks for the heads up chris!

    Posted 4 years ago #

RSS feed for this topic

Topic Closed

This topic has been closed to new replies.