ThemeShaper Forums » Thematic

[closed]

H1 tags on the home page

(6 posts)
  • Started 8 years ago by Danieliser
  • Latest reply from em hr
  • This topic is not resolved
  1. Danieliser
    Member

    Ok so i have on several builds now had to make changes to the core and maybe im wrong but isnt having more than 1 H1 tag on your index page a bad thing. I know in the archives and blog pages that you can h1 all the post titles. But it seems by default that the front_page() gets not only a h1 on the blogdescription but on the page title also. I like that it does h1 on the description for the home page.. allows you to accent main keywords but that should mean that the page title is h2. Or at least that is my understanding. I didnt want it linked either so this was my solution

    I added the following to the function thematic_postheader_posttitle() on line 1329 of content-extensions.
    change

    if (is_single() || is_page()) {

    to

    if ((is_single() || is_page()) && !is_front_page()) {

    and add this

    elseif (is_frount_page()) {
      $posttitle = '<h2 class="entry-title">' . get_the_title() . "</h2>\n";
    }

    Thought maybe this could be added if anybody agreed with me on this.

    Posted 8 years ago #
  2. I asked the same question a couple weeks ago here, not really sure if anyone really read it: http://forums.themeshaper.com/topic/2-h1-tags-on-home-page

    I agree with you that avoiding two H1 tags on any page is a good idea!

    Posted 8 years ago #
  3. Looking into this & tagging it: bug-report-open

    Posted 8 years ago #
  4. Danieliser
    Member

    I love what you guys have going here and want to help make it better. if possible lol. I would love to help on any developments you guys need. Im pretty proficient with php, wordpress, css, some ajax. ive written custom cms for clients and am pretty good with complex queries.

    Also i should add ive created half a dozen complex themes usig thematic now and have disected it pretty well. not all but most.

    Posted 8 years ago #
  5. @Danieliser thats great news.
    i'd maybe echo your intendended involvement here
    http://forums.themeshaper.com/topic/current-development-038-contributors-wanted

    Posted 8 years ago #
  6. Hi Danieliser,

    Yes please, come by http://forums.themeshaper.com/topic/current-development-038-contributors-wanted post there so we can keep track of who is interested in helping all in one place.

    -Gene

    Posted 8 years ago #

RSS feed for this topic

Topic Closed

This topic has been closed to new replies.