ThemeShaper Forums » Thematic

[closed]

more-link can not change langauge Thematic ver 1

(18 posts)
  • Started 2 years ago by soren
  • Latest reply from middlesister
  • This topic is resolved
  1. Hello!
    When using "more-link" I have no ability to change the "Read More" to lokal langauge!
    I have looked into the "po" file but there is no "more-link" to change!

    To solve the problem I used this function earlier, but in the new version 1.0 it does not work!?

    What is the correct way to do it?

    Thanks
    Soren

    function mytheme_excerpt_more($more) {
    	return '<a href="'. get_permalink() . '"> läs vidare…</a>';
    }
    
    add_filter('excerpt_more', 'mytheme_excerpt_more');
    Posted 2 years ago #
  2. can you move this to the new forums? www.thematictheme.com/forums

    Posted 2 years ago #
  3. I tried to but I can not get the registration! Message says I have to wait a few days for the activation!!!!

    Soren

    Posted 2 years ago #
  4. ok- not sure what is up with that. i'd register you if i had that kind of power. :)

    but what is the problem w/ the code you have posted? it works fine for me. see the temporary snapshot of my test child theme. http://awesomescreenshot.com/09e72z8ba

    if you check thematic_content() in content-extensions.php in the extensions folder, you will see that Thematic only calls

    $post .= get_the_excerpt();
    $post = apply_filters('the_excerpt',$post);

    to generate the excerpt whereever excerpts are being used. thematic never adds a "Read more" link of its own so this isn't something that you can translate via the theme. i suspect then, that the "read more" is the default text from wordpress for an english language installation. (and if it is the default text for other languages too then it is a problem with wordpress translations)

    Posted 2 years ago #
  5. Helga,

    The registration does not send the actvation email... tried 3 times now and got this message. I'm not seeing any message in my inbox!

    I misread the message, it says that the account can be available in a few days as it is registred already.... I will try with another email to see if it works!

    About the excerpt!

    This is very strange as I can not get the result as you get!!

    Have a look here for example. http://www.digitalworkflow.se/ (childtheme "thematicfeaturesite")

    I am also working on a new childtheme localy by ScottNix "Responsive Base" and have exactly the same result!!!

    Posted 2 years ago #
  6. The reason for this is probably because the mo and po files were out of sync. It looks like Chris got them back in sync with the latest trunk in the svn as well as updating the German language files.

    Try this:
    http://thematictheme.com/latest-stable-trunk/thematic-1011.zip

    and let me know if it corrects the issue.

    Posted 2 years ago #
  7. Sorry to say it.. but the answer is no, it does not correct the issue!

    It worked in version 0.9.7.7

    I have updated both the website and my local install, the issue is still there!

    Can it be something with that I am using a non-english version of WordPress?

    Posted 2 years ago #
  8. Did test with the latest wordpress (3.4 Release Candidate) and the issue is still there, so it does not have something to do with non-english versions...

    Posted 2 years ago #
  9. middlesister
    Member

    I think you are targeting the wrong filter. The 'excerpt_more' filter is called on generated excerpts only. Since I see you have images showing, I assume you are using the <-more-> tag in the editor (images are not shown on generated excerpts).

    Thematic has a filter for this called 'more_text', but the more text *is* localized. It seems the Swedish localization is not very up to date. Lucky for you, I am Swedish! :D. I can update the Swedish localization. Until then, changing the filter to

    function mytheme_excerpt_more($more) {
    	return 'läs vidare…';
    }
    
    add_filter('more_text', 'mytheme_excerpt_more');

    will probably do the trick.

    Posted 2 years ago #
  10. The problem still exists that we shouldn't have to filter that string if we are translating using I18in. It should do it for us. The reason why it isn't working in this case is because the Swedish .po file is out of sync. Middlesister, my Swedish is not so good lol can you update the sv_SE.po export the mo and commit it?

    Sorry... should have read m's post all the way through first.

    Posted 2 years ago #
  11. the "read more" link isn't even translated by thematic, at least not for excerpts. can you activate another theme, drop your mytheme_excerpt_more() function into the functions.php and let us know what happens?

    as an anglophile i'm quite lazy about knowing how translations work, but i just installed the French translation (so i could atleast read it) and your function still works (that function is straight from the codex so it is something else)

    in fact, "read more" isn't even the default "more" text. without any adjustment, the more text should read: [...] do you have any plugins active that might be interfering? try disabling them all. you could also add a priority to your filter so that it runs later, after anything else that might be interfering.

    Posted 2 years ago #
  12. helga... believe me the "read more"... bit is translated in Thematic the translations are out of sync because I had taken on the effort of removing markup, leading & trailing whitespace & punctuation from the translation strings. And the translations did not get updated before the release

    http://code.google.com/p/thematic/issues/detail?id=123

    Posted 2 years ago #
  13. middlesister,

    Correct I am using the <-more-> tag instead of the generated excerpts just to have a little more control!

    Thanks that did the work! I think there is more on the swedish localisation that needs to be done, I did see another error about "response" I think... have to look...

    Great! Back on track! :) Tack så mycket!

    Posted 2 years ago #
  14. I did find another translating issue! When you have comments on post it will not translate to Swedish! It says for example "1 Response"

    Thanks for all help!

    Posted 2 years ago #
  15. it's all becoming clear to me!! from your code i didn't pick up on the fact that you were using the <more> tag (b/c apparently i didn't read closely either). totally different can of worms from what i was talking about. that more_text() filter is (or should be) translated by thematic. the more text link i was describing (auto-generated for truncated excerpts) is not.

    i am not swedish, so i am totally useless for the translations... unless skoll is in there somewhere! speaking of, it is time for a paloma.

    Posted 2 years ago #
  16. Most of the translators don't update the language file or update it against the thematic.pot which was out of sync.

    Thematic.pot is in sync again, but should be tested by the translators. In addition it would be great if the German users could check the latest German language files.

    Sören, could you help us with the Swedish file? Isn't that difficult. Install POedit, grab the latest SVN copy of Thematic, start POedit, load the Swedish file, upgrade it againt thematic.pot and start translating.

    Chris

    Posted 2 years ago #
  17. Chris,

    Yes I will have a look at it, I have updated a few plugins over the years so I have the POedit installed!

    Thanks

    Posted 2 years ago #
  18. middlesister
    Member

    @sören: I just made an updated translation. I can commit the file to the svn repo, but if you give me you email address I can send it to you directly. And if you spot any errors or anything you find weird, please do tell so we can make it better. My email is invistruct at gmail

    Posted 2 years ago #

RSS feed for this topic

Topic Closed

This topic has been closed to new replies.