ThemeShaper Forums » Thematic


New theme - need review please

(5 posts)
  • Started 7 years ago by Jagst3r15
  • Latest reply from Jagst3r15
  • This topic is not resolved
  1. Hey guys, I have been hard at work trying to develop some free Thematic child themes to release and am very close to being done with one of them, called "Standard." Could some people here take a look at it and tell me what you think? I intend to release version 1.0 tomorrow, even though I want to implement some other features (I'll do that in another version).

    You can view a demo here:

    Note that the xhtml has 6 errors, but I know what they are caused by, the p tag in my more tag ... not sure how to get rid of them. There are also alot of CSS errors, but that's because I use some CSS3 - it is valid, just not in accordance with CSS 2.1 (still works though, so no worries there).

    Posted 7 years ago #
  2. I would highly suggest if you are looking to really stress test your layouts to use the Theme Unit Test data used for reviews.

    Couple things to fix.

    • The blog post box is different than the individual post/page box, different paddings/widths.
    • You don't need to bother prefixing (-moz, -webkit) border-radus and box-shadow anymore, you are welcome for the time savings in the future.
    • The <p></p> link issue you already know about.

    Me being anal, you could probably get away with leaving these.

    • Few areas where there is a !important where it isn't necessary, for example #subsidiary css.
    • Combine the stylesheets @imports into the style.css also. Why is stripes.css on its own?
    • The actual theme folder, change Standard to standard, lowercase.

    And if you really want to step up the game.

    • Use my fake HTML5 Header for Thematic which best of all provides conditional classes.
    • Wipe out the superfish drop down scripts, enqueue them correctly, combine them into one file and reload them in the footer.
    • You could enqueue jQuery in the footer for fun too.
    • Clean up the header area in Thematic

    I was honestly expecting to find a lot more things I could suggest, but it is so simple and is visually pretty clean in my opinion. (I like clean)

    Also the validators are fairly useless now for acheiving "100% valid pages" but they are still very useful for scouting errors. Like the incorrect nesting in the html above which you know about.

    Last thing, when you prefix stuff for newer css3, just make sure to include a non prefixed property at the bottom to be safe (if they ever drop support, or other browsers come along, futureproof)

    -webkit-transform: scale(0.8);  /* Saf3.1+, Chrome
         -moz-transform: scale(0.8);  /* FF3.5+
          -ms-transform: scale(0.8);  /* IE9
           -o-transform: scale(0.8);  /* Opera 10.5+
              transform: scale(0.8);  /* Future Proof It! */
    Posted 7 years ago #
  3. Thanks for the extensive feedback. I'm going to clean it up some more tomorrow and see where I get. I think I might add breadcrumb support as well, which isn't too hard I don't think. Going to use all of your suggestions though, since I think they'll all help a lot -- the widths of the pages was annoying, since I think the full page width is busted (I believe they are fixing this for the next release) and I adjusted it but never fixed it, so will do that for sure.

    And I do tend to get !important crazy sometimes ;)

    Posted 7 years ago #
  4. WordPress SEO Plugin has a breadcrumb option in it. Just in case you didn't know. ;P

    Posted 7 years ago #
  5. Yep, knew that. Just meant adding the necessary php line and css styles for it, so the user doesn't have to touch code if they don't want.

    ...and damn, I forgot to style the comments/reply sections (the width of the text area gets cut off in reply's as well). Looks like I got a little work to do before I make the download link available ;)

    Posted 7 years ago #

RSS feed for this topic

Topic Closed

This topic has been closed to new replies.