ThemeShaper Forums » Development Talk

[closed]

Possible mods to Thematic

(3 posts)
  • Started 2 years ago by ScottNix
  • Latest reply from middlesister
  1. Maybe it is just me, but there are things I end up doing on every single Thematic install.

    What would be a negative to adding a clearfix code/class to Thematic instead of using the overflow trick for float collapse?

    I end up always applying a clearfix to at least the main div (usually because repeating background). This is most easily done by adding a class with jQuery.

    // add micro clearfix classes
    jQuery("#subsidiary, #main").addClass('cf');
    /* For modern browsers */
    .cf:before, .cf:after { content:""; display:table; }
    .cf:after { clear:both; }
    /* For IE 6/7 (trigger hasLayout) */
    .cf { zoom:1; }

    So the jQuery solution works fine... Although, why can you modify the #wrapper, but not the #header or #main.

    The wrapper is coded

    if (apply_filters('thematic_open_wrapper', true)) {
    echo ('<div id="wrapper" class="hfeed">' . "\n");
    }

    And is modifiable like so.

    function childtheme_open_wrapper() {
    	echo '<div class="wrap shit">';
    }
    add_filter ('thematic_open_wrapper', 'childtheme_open_wrapper');

    Why can't #header/#main and some of the other hard coded divs be the same as the wrapper? I ask because it might be possible that someone might not want or care about divs clearning floats, I can't really think of a reason...

    Posted 2 years ago #
  2. i'd love to see the classes on a lot of items be filterable. lots of layout possibilities would open up.. you could pretty much switch to any CSS layout framework imaginable

    <div id="header" class="<?php echo apply_filters('thematic_header_class','full-width');?>">
    Posted 2 years ago #
  3. middlesister
    Member

    +1 for filterable div's. Apart from CSS frameworks (like using conditionals to get tailored grid column css classes) it would also make it possible to switch to html5 <header> and <footer> elements.

    Posted 2 years ago #

RSS feed for this topic

Topic Closed

This topic has been closed to new replies.