ThemeShaper Forums » Thematic

suggestion to clean up theme files

(3 posts)
  • Started 10 years ago by dwenaus
  • Latest reply from Ian Stewart
  • This topic is not a support question
  1. I'm just looking through the template files, and wanted to make a suggestion. It seems that the page navigation code has grown quite large and now dominate the code for pages such as index.php, tags.php, etc. perhaps this code:
    <div id="nav-above" class="navigation">
    <?php if(function_exists('wp_pagenavi')) { ?>
    <?php wp_pagenavi(); ?>
    <?php } else { ?>
    <div class="nav-previous"><?php next_posts_link(__('<span class="meta-nav">«</span> Older posts', 'thematic')) ?></div>
    <div class="nav-next"><?php previous_posts_link(__('Newer posts <span class="meta-nav">»</span>', 'thematic')) ?></div>
    <?php } ?>
    </div>

    could be replaced with a simply function which passes 'before' or 'after' and any other necessary items. call it something like thematic_nav_post_links() or thematic_next_prev_links

    also, single.php seems to be missing the wp_pagenavi option, maybe that is on purpose.

    I could help with this coding, but I've never used svn. If that kind of help is welcome, and agreed upon, please point me in the right direction to make this kind of change.

    Cheers,
    Deryk

    Posted 10 years ago #
  2. is this the place to discuss this? are folks open to this? if yes, I can make the change and either submit the code for approval, or enter it into trunk. (i'm new at svn)

    Posted 10 years ago #
  3. The navigation being cleaner is something I'd like to see, so yeah. :) See my thoughts about version 1.0.

    (Also, pagenavi isn't for single posts)

    Posted 10 years ago #

RSS feed for this topic

Reply

You must log in to post.