ThemeShaper Forums » Thematic

[closed]

Thematic Options - the Helga Fork

(18 posts)
  • Started 3 years ago by helgatheviking
  • Latest reply from d_rec
  • This topic is not a support question
  1. I decided to fork Devin's Thematic Options child framework. I had tinkered with the idea back in version 1.0, but his 2.0 is just flat out cool looking and so was a really great starting point.

    My fork includes:

    nonces
    saving all the options to one array
    using a Class to store the options panel and its defaults
    using wp_enqueue_style for the options that change the styles/layout

    it is hosted at github
    https://github.com/helgatheviking/thematic-options-KIA

    Let me know what you think and if you come across any errors.

    to do:
    data validation- apparently the Settings API does this automatically, but I couldn't figure out how to make the settings API (who knew there was one!?) play with ajax

    add options for toggling excerpts and the display of the blog description

    Happy New Year and Bon Année!

    Posted 3 years ago #
  2. shameless bump. could really use a little testing/feedback help.

    Posted 3 years ago #
  3. nickbernier
    Member

    Its really great and I would like to customize my own down the road. The layout (2c l.css) option and many of the other css based options work, however the header image uploader hasn't been working for me?

    Also, I've tried to add another layout option, a single column with no sidebar. (working on photographer's showcase, wants large images and no sidebar). When trying to add the custom 1c.css layout option in the admin php file, I also attempted to insert the remove sidebar php code that I would normally put in the child theme functions.php file. Anyway, this fails, would I hard code this in the childtheme functions.php or can it be integrated into the option page therefore only removes sidebar when user toggles 1 column option?

    I played with it last night, using Wordpress 3.0.4 and noticed this at the top of the plugin page:

    http://write.fm/79wt64p (screenshot of it)

    Sorry if this is not making any sense, I'm at work and don't have access to my set up!

    Nick

    Posted 3 years ago #
  4. hi nick,

    thank you so much for the feedback. for the single column layout, i would probably add the CSS file into the folder with the others. then in the function that actually adds the CSS to the header, i'd add a conditional (if $template=single-column.css or whatever) that kills the sidebar.

    i'm surprised to hear that the uploader doesn't work. it does for me and that is probably the part i fiddled with the least... almost not at all. I will have to look more into that. can you give me more details later? the problem i've noticed is w/ trying to set a "default" image... you can still remove that. which i guess is only a problem in certain cases.

    the data that shows up in the screentshot is just something i have in for debugging. i have since commented it out.

    Posted 3 years ago #
  5. nickbernier
    Member

    Alright, gave it a shot again tonight...and it worked! I was using Chrome last night and despite clearing the cache it wasn't refreshing? Tried it tonight with FF and Safari on Mac and works like a charm!

    I'll keep fiddling with the single column option and I'll let you know when I get it right.

    Thanks again and great work!

    Posted 3 years ago #
  6. well i am relieved! i went ahead and included the single column option. i also updated the others w/ their current thematic versions (since those include styles for the full-page templates that were missing from the options theme versions).

    Posted 3 years ago #
  7. Hi Helga,

    Thank you for the wonderful fork on Thematic options panel.

    However, I stumbled upon an issue. If I toggle the check or uncheck state of any checkbox type option on the panel and then hit "Save All Changes" button. It says "Options Updated." But the updated state/value of the checkbox setting does not get saved nor updated on the $data array. Furthermore, if I refresh the Thematic Options panel, the checkbox displays the old/unchanged state.

    I found that I had to also change at least one value of other 'text', 'textarea', or 'select' type option for the changes I made to checkbox type options to be saved.

    Only have issue with checkbox state changes not getting saved if only checkboxes were changed.

    Am using Wordpress 3.0.4, Thematic 0.9.8, thematic-options-KIA-2.2, Firefox 3.6.13, Chrome 8.0.522, and a custom Thematic child theme.

    Any idea why checkbox type options behaves this way for me?

    Thanks again for your enhancements on the Thematic options panel!

    Posted 3 years ago #
  8. hi gamernfo! thanks for checking it out and reporting back- it is pretty much impossible to fully test something by yourself. all the code starts to blur together!

    i will have to check this out later...

    Posted 3 years ago #
  9. gamerinfo- could i trouble you to ensure that you are using the latest files? i could not recreate the error as all checkboxes save properly for me.

    Posted 3 years ago #
  10. Using thematic-options-KIA-2.2-5. Without changes, the examples work perfectly without issue.

    Only had the 'checkbox not saving its changes' issue, after I added the code shown below to the end of function of_options() in file theme-options.php.

    "New Options" section would appear right after "Example Options" on the theme options panel. Then I do an "Options Reset", toggled the checkbox states and "Save All Changes." First, it did save the changes correctly. But after that, any changes I made to those checkboxes (without altering other inputs) fails to save.

    $my_options[] = array( "name" => "New Options",
    			"type" => "heading"); 		
    
    $my_options[] = array( "name" => "Do not repeat posts.",
    			"desc" => "If enabled, shows posts on index page only once even if post matches several categories or tags. Default is Enabled.",
    			"id" => "post_show_only_once",
    			"std" => true,
    			"type" => "checkbox");
    
    $my_options[] = array( "name" => "Show post thumbnails",
    			"desc" => "Show thumbnails for posts. Default is Enabled.",
    			"id" => "post_show_thumbnail",
    			"std" => true,
    			"type" => "checkbox");

    Maybe, I did something wrong? =)

    Thanks again for the help.

    Posted 3 years ago #
  11. ok- i'm finally able to reproduce what you are experiencing. i don't know the solution yet, but i'm looking into it and hopefully i will be able to figure it out.

    Posted 3 years ago #
  12. @gamernfo - wow that took all day, but i believe i have solved the problem. please get the latest files from github and let me know if they solve your problem.

    also if you wouldn't mind, Devin contacted me today asking about another bug he is experiencing. Could you try clearing your cache, activating the new theme, and then immediately try to upload an image. the comments on his blog suggest there is a problem there in Chrome and Safari that I haven't been able to reproduce. I'd appreciate the help.

    Posted 3 years ago #
  13. Thank you Helga. With the new update, the checkboxes works as expected.

    Regarding the uploading of image, I've tried it on Chrome and Safari, works without issues. Did it like you've suggested: cleared cache, activated new theme, and upload image. It uploaded the image fine without problem and displayed it as well.

    Thanks again for the fix and have a great day! =)

    Posted 3 years ago #
  14. thanks for helping with the bug fixes, I really appreciate it. Just like Thematic, 1 set of eyes is not enough. Devin squashed his bug too... so I've added that code into the KIA fork as well. It was just a timer that delays a bit if AjaxUpload hasn't finished loading. I also cleaned up the admin-style.css and made the rounded corners hopefully cross-browser compatible. since you probably haven't gotten super far in the last 3 hours I'd suggest getting my last updates and work from there.

    next update is sort of far off so, barring the discovery of more bugs, I shouldn't be making many changes.

    Posted 3 years ago #
  15. Hi Helga!

    Great job with your thematic-options-KIA which I got at github and managed to install on my little network (http://berkshires.co) - so far only changing header images per site but as the network grows I'm sure to be developing unique looks for various sites.

    I'm all over the networkability of wp 3+ and thematic and its totally fabulous support community. While getting into the whole multisite thing I couldn't help but try out various other setups and related support - tried 'em all and always revert back to thematic and company.

    There are a few other multisite threads running loose here, as you know; some way of grouping them may be helpful. E.g., do you think your solution would be a good option for what's described in this post?
    http://forums.themeshaper.com/topic/loading-separate-css-sheet-per-site#post-15598

    Gratefully yours,
    Dave

    Posted 3 years ago #
  16. You can look at the plugin I just released: http://wptheming.com/options-framework-plugin/

    It works a bit differently because it stores the options for each theme in a different database option by default.

    But you would have to do just a slight tweak in your theme to have it store the options in a sitename.

    And now that I think about it, you could also that with Kathy's project as well.

    Posted 3 years ago #
  17. i think in functions.php i define the name of the DB entry

    define('OPTIONS', 'kia_options'); //name of entry into database - will break DB if this has spaces!

    you might be able to adjust this to reflect both theme name AND in your case of multisite.... blogID# ? that should get you a bunch of unique DB entries. i haven't tested it and since I'm moving to using Devin's plugin for all my options so i'm not sure how much more i will be developing my own options framework... i've moved to trying to create new grids for thematic. but if you figure it out submit a pull request on git and i'll make the change b/c it is a cool idea.

    $safename = strtolower(get_current_theme());
    
    //should run it through some kind of preg_replace to strip out spaces and ' " characters
    
    define('OPTIONS', get_current_blog_id() . '_' . $safename);
    Posted 3 years ago #
  18. Helga, I've been having a play with this theme(2.2) in Chrome and FF4(localhost) and when I expand the options page and then shrink it again the formatting goes astray. The 'Custom Logo' title ends up sitting below the Example Options title.

    Now back to learning about Meta Boxes and all that fun stuff.

    Posted 3 years ago #

RSS feed for this topic

Topic Closed

This topic has been closed to new replies.