Based on the Theme review checklist at http://codex.wordpress.org/Theme_Review i created an actual checklist
http://www.kathyisawesome.com/2012/wordpress-theme-development-checklist/
this isn't the best venue, but let's use this thread to volunteer to take a section of the checklist and verify that the thematic SVN passes all the requirements. some of the sections are super easy, some are more involved.
how to get the latest SVN
http://forums.themeshaper.com/topic/how-to-get-the-latest-svn-copy-of-thematic
so post w/ what section you've taken, and what your results were, whether you've submitted a patch, etc. i'll try to keep this main list up-to-date w/ who's doing what and their status.
Code Quality
status: reviewed and 2 issues pending
- php, js, css, html --> resolved
- doctype declation --> resolved
- theme namespacing--> helga
- themes are req'd to use a unique slug as a prefix for all custom function names, classes, public/global variables, database entries (theme options, post custom metadata, etc). recommended to use theme-slug as this unique slug.
- so far there are functions in sidebar-extensions.php, shortcodes.php, header-extensions.php and content-extensions.php that don't start with the thematic_ prefix.
- there are classes in widgets.php that don't start with the thematic prefix.
- there are constants in init.php that don't start with thematic_prefix
- if this applies to filter names too then i need to verify that the filters that don't start with thematic_ are, in fact, WP filters. the_content, the_excerpt and the like i know, but there are some more obscure ones that i don't know off the top of my head.
Functionality
status: reviewed and 2 issues pending
NB: need someone to verify the internationalization works and that all strings are accounted for
- Automatic feed Links --> helga, OK
- Widgets --> middlesister, OK
- Comments --> helga
- need comments_class() function. i suspect we'll need to use it in the same way we are using constants to override body and post classes...ie by default but with the potential to be overriden
- Navigation Menus --> helga
- register_nav_menu() should be in functions.php
- Post Thumbnails --> helga
- add_theme_support('post-thumbnails') is supposed to be in functions.php. it is in init.php in the extensions.php folder. i'd make a case that everything in init.php should be moved back to functions.php where most of it used to be. --> patch submitted
- Custom Header --> helga, N/A
- Custom Background --> helga, N/A
- Visual Editor CSS --> helga, N/A
- Translation/Internationalization
Template Tags and Hooks
status: reviewed and 3 pending
- required hooks and navigation -->middlesister, OK
- including files --> middlesister, OK
- including stylesheets and scripts --> helga
- enqueue scripts on wp_enqueue_scripts hook > patch for init.php
- including other resources --> helga, OK
- site information
- get_feed_link() and get_stylesheet_uri instead of get_bloginfo() equivalents > patch for header-extensions.php
Wordpress-Generated CSS Classes
status: reviewed and OK!
- Support of required classes --> middlesister, OK
Theme Template Files
status: reviewed and 1 issue pending
- required minimum template files --> helga, OK
- recommended templates --> helga, OK
- option templates --> helga, OK
- core forms
- login form: must be included using wp_login_form() - do we think this means only if the theme adds a login form that is must be called properly? not that the theme must include a login form?
- not recommended templates --> helga, OK
Theme Settings and Data Security
status: needs review
Licensing --> helga, OK
status: reviewed and OK!
- license
- up-sell themes
- bundled resources
Theme Name --> helga, OK
status: reviewed and OK!
Credit Links
status: reviewed and OK!
you are allowed 1 credit link. any others must be opt-in and off by default. thematic's is on by default but as a theme option is changeable, which i think is ok since there isn't a forced-use link.
Theme Documentation
status: reviewed and OK!
Theme Unit Tests
status: reviewed by middlesister, multiple issues pending
http://codex.wordpress.org/Theme_Unit_Test
