ThemeShaper Forums » Thematic

[closed]

Where do We submit changes/upgrades to thematic

(6 posts)
  • Started 13 years ago by ductiletoaster
  • Latest reply from helgatheviking
  • This topic is not a support question
  1. Title says it all!!!
    Where do We submit changes/upgrades to thematic?

    Simple change.... in the search.php.
    There is an if else statement.
    In the else section there is some code used to tell notify when a search comes up empty.
    Well i like to customize that so in order to do that i have to make a search.php in my child theme. So i suggest that that code be placed in a function called thematic_noresults()

    I already did this on mine site as to simplify my child themes code.

    Posted 13 years ago #
  2. i dont think they let everybody submit changes to the hosted version. you could share your code here, and if it is really good i am sure gene and chris will add it in.

    Posted 13 years ago #
  3. Anyone who wants to offer code or report bugs can do so here: http://code.google.com/p/thematic/

    Cheers,
    Gene

    Posted 13 years ago #
  4. hi gene,

    how exactly does one go about submitting code over there? the only thing i can really see might be 'Add issue'? Except that i don't want to report a problem. I modified thematic_comment_link() to add a hook for a default avatar.

    // Produces an avatar image with the hCard-compliant photo class
    function thematic_commenter_link() {
    	$commenter = get_comment_author_link();
    	if ( ereg( '<a[^>]* class=[^>]+>', $commenter ) ) {
    		$commenter = ereg_replace( '(<a[^>]* class=[\'"]?)', '\\1url ' , $commenter );
    	} else {
    		$commenter = ereg_replace( '(<a )/', '\\1class="url "' , $commenter );
    	}
    	$avatar_email = get_comment_author_email();
    	$avatar_size = apply_filters( 'avatar_size', '80' ); // Available filter: avatar_size
    	$default_avatar = apply_filters( 'default_avatar', ''); // Available filter: default_avatar
    	$avatar = str_replace( "class='avatar", "class='photo avatar", get_avatar( $avatar_email, $avatar_size, $default_avatar ) );
    	echo $avatar . ' <span class="fn n">' . $commenter . '</span>';
    } // end thematic_commenter_link

    then in the child theme the default can be set using

    function childtheme_default_avatar() {
        return get_stylesheet_directory_uri() . '/images/default_avatar.png' ;
    }
    add_action( 'default_avatar', 'childtheme_default_avatar' );
    Posted 13 years ago #
  5. You can simply submit your feature/enhancement suggestion as an "issue" Its all good. The reality is not every enhancement will make it into the theme.

    Sharing code around here generally works better with strictly child theme *only* solutions. Less chance of luring someone into editing the parent theme.

    Posted 13 years ago #
  6. well cool. i did submit it as an 'issue'. i just wasn't sure since it seemed more like a 'suggestion'.

    i hope i didn't lure anyone into editing the parent files!

    DON'T TOUCH THEMATIC, PEOPLE!

    Posted 13 years ago #

RSS feed for this topic

Topic Closed

This topic has been closed to new replies.